Re: [PATCH 2/3] HID: cp2112: add HIDRAW dependency

From: Benjamin Tissoires
Date: Mon Nov 06 2017 - 03:12:29 EST


On Nov 02 2017 or thereabouts, SÃbastien Szymanski wrote:
> Otherwise, with HIDRAW=n, the probe function crashes because of null
> dereference of hdev->hidraw.
>
> Fixes: 42cb6b35b9e6 ("HID: cp2112: use proper hidraw name with minor number")
> Signed-off-by: SÃbastien Szymanski <sebastien.szymanski@xxxxxxxxxxxx>

Patches 1 and 2 (only) are:
Acked-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

> ---
> drivers/hid/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 374301f..8c7a0ce 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -230,7 +230,7 @@ config HID_CMEDIA
>
> config HID_CP2112
> tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
> - depends on USB_HID && I2C && GPIOLIB
> + depends on USB_HID && HIDRAW && I2C && GPIOLIB
> select GPIOLIB_IRQCHIP
> ---help---
> Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
> --
> 2.7.3
>