Re: [PATCH v4] tty: serial: meson: allow baud-rates lower than 9600

From: Martin Blumenstingl
Date: Sun Nov 05 2017 - 10:03:08 EST


Hi Thomas,

thank you for this patch!

On Sun, Nov 5, 2017 at 3:12 PM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Sun, Nov 05, 2017 at 05:29:30AM +0100, Thomas Rohloff wrote:
>> Devices like DCF77 receivers need the baud-rate to be as low as 50.
>>
>> I have tested this on a Meson GXL device with uart_A.
>>
>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> Cc: Jiri Slaby <jslaby@xxxxxxxx>
>> Cc: Carlo Caione <carlo@xxxxxxxxxx>
>> Cc: Kevin Hilman <khilman@xxxxxxxxxxxx>
>> Cc: linux-amlogic@xxxxxxxxxxxxxxxxxxx
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> Signed-off-by: Thomas Rohloff <v10lator@xxxxxxxx>
>> ---
>> drivers/tty/serial/meson_uart.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/meson_uart.c
>> b/drivers/tty/serial/meson_uart.c
>> index 07c0f98be3ac..e281ce5d101d 100644
>> --- a/drivers/tty/serial/meson_uart.c
>> +++ b/drivers/tty/serial/meson_uart.c
>> @@ -362,7 +362,7 @@ static void meson_uart_set_termios(struct uart_port
>> *port,
>
> This is line-wrapped and can not be applied :(
>
> It's your email client, look at this setting:
> Content-Type: text/plain; charset=utf-8; format=flowed
>
> format=flowed does not work for kernel patches, it corruptes and edits
> them as it thinks this is just a conversation, not a machine-readable
> format.
>
> 5th try? :)
if you send a 5th version, please also include Neil's "Reviewed-by"
just below your Signed-off-by:
Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>

you can do this by running git commit --amend - this lets you edit the
existing commit message so you can append that


Regards,
Martin