Re: [PATCH] net: sched: cls_u32: use bitwise & rather than logical && on n->flags

From: David Miller
Date: Sat Nov 04 2017 - 09:52:18 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Fri, 3 Nov 2017 08:09:45 +0000

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently n->flags is being operated on by a logical && operator rather
> than a bitwise & operator. This looks incorrect as these should be bit
> flag operations. Fix this.
>
> Detected by CoverityScan, CID#1460398 ("Logical vs. bitwise operator")
>
> Fixes: 245dc5121a9b ("net: sched: cls_u32: call block callbacks for offload")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied, thanks Colin.