Re: [PATCH v3] cpufreq: schedutil: Examine the correct CPU when we update util

From: Viresh Kumar
Date: Fri Nov 03 2017 - 11:46:09 EST


On 03-11-17, 13:36, Chris Redpath wrote:
> After
> 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks")
>
> We stopped always reading utilization for the cpu we are running
> the governor on, and instead read it for the cpu which we've been
> told has updated utilization. This is stored in sugov_cpu->cpu.
>
> The value is set in sugov_register but we clear it in sugov_start
> which leads to always looking at the utilization of CPU0 instead
> of the correct one.
>
> Let's fix this by consolidating the initialization code into
> sugov_start().
>
> Fixes: 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks")
> Signed-off-by: Chris Redpath <chris.redpath@xxxxxxx>
> Reviewed-by: Patrick Bellasi <patrick.bellasi@xxxxxxx>
> Reviewed-by: Brendan Jackman <brendan.jackman@xxxxxxx>
> Cc: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> ---
> kernel/sched/cpufreq_schedutil.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh