Re: usb/misc/ims-pcu: slab-out-of-bounds in ims_pcu_parse_cdc_data

From: Dmitry Torokhov
Date: Thu Nov 02 2017 - 12:25:42 EST


Hi Andrey,

On Thu, Nov 2, 2017 at 9:13 AM, Andrey Konovalov <andreyknvl@xxxxxxxxxx> wrote:
> On Sat, Oct 7, 2017 at 8:14 PM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
>> On Thu, Sep 28, 2017 at 01:35:51PM +0200, Andrey Konovalov wrote:
>>> Hi!
>>>
>>> I've got the following report while fuzzing the kernel with syzkaller.
>>>
>>> On commit dc972a67cc54585bd83ad811c4e9b6ab3dcd427e (4.14-rc2+).
>>>
>>> There's no check that the length of intf->altsetting->extra is big
>>> enough to hold usb_cdc_union_desc struct.
>>
>> Can you please tell me if the following works for you?
>
> Hi Dmitry,
>
> Could you mail this patch upstream?

It is already there:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/input/misc/ims-pcu.c?id=ea04efee7635c9120d015dcdeeeb6988130cb67a

Thanks.

--
Dmitry