Re: [PATCH v7 2/2] bus: add driver for the Technologic Systems NBUS

From: Sebastien Bourdelin
Date: Thu Nov 02 2017 - 10:37:55 EST


Hi Linus,

On 11/02/2017 10:22 AM, Linus Walleij wrote:
> On Wed, Nov 1, 2017 at 6:14 PM, Sebastien Bourdelin
> <sebastien.bourdelin@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>> This driver implements a GPIOs bit-banged bus, called the NBUS by
>> Technologic Systems. It is used to communicate with the peripherals in
>> the FPGA on the TS-4600 SoM.
>>
>> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@xxxxxxxxxxxxxxxxxxxx>
>> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> This is still a very nice driver.

Thanks that's very kind and greatly appreciate.
>
> If you are working on supplemental patches: from the next merge window
> we will have:
>
> + int gpiod_get_array_value_cansleep(unsigned int array_size,
> + struct gpio_desc **desc_array,
> + int *value_array);
>
> See:
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/commit/?h=devel&id=eec1d566cdf94b57e8f5ba9fe60eea214929bcfc
>
> If your GPIO controller also has .get_multiple() implemented it just
> becomes one register read if you're lucky.
>
Ok, i guess i will not if this is fine like that, i'll see if someone
suggested some changes.

> BTW do you have a way upstream for this patch? ARM SoC?
Honestly i have no idea, do you have a recommandation for this kind of
bus driver? should i re-submit just this patch to a specific tree?

>
> Yours,
> Linus Walleij
>

Thanks again for your inputs.

Best regards,
Sebastien Bourdelin.