Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns

From: Tom Saeger
Date: Wed Nov 01 2017 - 13:12:37 EST


On Wed, Nov 01, 2017 at 09:50:05AM -0700, Joe Perches wrote:
> (add mercurial-devel and xen-devel to cc's)
>
> On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote:
> > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid
> > "F" and "X" patterns found in MAINTAINERS file(s).
>
> Hey again Tom.
>
> About mercurial/hg.
>
> While as far as I know there hasn't been a mercurial tree
> for the linux kernel sources in many years, I believe the
> mercurial command to list files should be different.
>
> > my %VCS_cmds_hg = (
> > @@ -167,6 +169,7 @@ my %VCS_cmds_hg = (
> > "subject_pattern" => "^HgSubject: (.*)",
> > "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$",
> > "file_exists_cmd" => "hg files \$file",
> > + "list_files_cmd" => "hg files \$file",
>
> I think this should be
>
> "list_files_cmd" => "hg manifest -R \$file",

Ok - I'll add to v2.