Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns

[Tom Saeger]

On Wed, Nov 01, 2017 at 08:32:51AM -0700, Joe Perches wrote:
> On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote:
> > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid
> > "F" and "X" patterns found in MAINTAINERS file(s).
> 
> Hey Tom.
> 
> I've come around to this addition, but I think a few
> changes are useful.
> 
> o Change --pattern-checks to --self-test so future checks
>   can be added (valid email address, .mailmap uses, existence
>   of git trees, etc...)

Ok.

Had similar thoughts.  Was just looking at git trees.

> o Do not require an unnecessary argument with --self-test

Ok.

> o Validate --self-test if it is the only command line argument

Ok.

> o Use emacs filename:line: style output for easier linking

Ok.

> o --self-test emits to STDOUT not STDERR

Ok - I debated this one, I'll change it back.


Thanks for your input Joe, I'll send a v2.

--Tom