Re: [PATCH v4 2/2] mfd: Add Spreadtrum SC27xx series PMICs driver

From: Baolin Wang
Date: Wed Nov 01 2017 - 05:33:18 EST


Hi Lee,

On 1 November 2017 at 17:27, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> On Wed, 01 Nov 2017, Baolin Wang wrote:
>
>> This patch adds support for Spreadtrum SC27xx series PMIC MFD core, and It
>> provides communication through the SPI interfaces. The SC27xx series PMICs
>> contains the following 6 major components:
>> - DCDCs
>> - LDOs
>> - Battery management system
>> - Audio codec
>> - User interface function, such as indicator, flash LED
>> - IC level function, such as power on/off, type-c
>>
>> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxx>
>> ---
>> Changes since v3:
>> - Use memcpy() to copy register offset address into SPI buffer.
>>
>> Changes since v2:
>> - Add more help information.
>> - Define macros for irq base and irq number.
>> - Use devm_mfd_add_devices() instead of mfd_add_devices(), which means
>> we can remove sprd_pmic_remove().
>> - Rename local variables in sprd_pmic_probe().
>>
>> Changes since v1:
>> - Add more documentation to introduce Spreadtrum SC27xx series PMICs.
>> - Modify compatile string property.
>> - Modify reg property.
>> - Remove redundant 'pmic' label.
>> - Change 'should be' to 'must be' for cells properties.
>> ---
>> drivers/mfd/Kconfig | 16 +++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/sprd-sc27xx-spi.c | 259 +++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 276 insertions(+)
>> create mode 100644 drivers/mfd/sprd-sc27xx-spi.c
>
> Applied, thanks.

Thanks for your help.

--
Baolin.wang
Best Regards