Re: [PATCH v11 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens

From: Darren Hart
Date: Tue Oct 31 2017 - 11:24:18 EST


On Mon, Oct 30, 2017 at 01:36:16PM +0000, Mario.Limonciello@xxxxxxxx wrote:
> >
> > Hint: you can move this check out of j-loop as condition is independent
> > of it.
>
> That's true, thanks.
>
> >
> > Also how many tokens are there? Is not quadratic solution too slow?
> >
>
> ~< 250 on most machines is what I've seen. To me that that's a small
> enough number that this is quick. It only happens at initialization.

Agreed, not a hot path. Prefer simplicity to performance here.

--
Darren Hart
VMware Open Source Technology Center