Re: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun

From: Cathy Avery
Date: Tue Oct 31 2017 - 08:31:22 EST


On 10/31/2017 08:24 AM, Martin K. Petersen wrote:
If you use alloc_ordered_workqueue directly instead of
create_singlethread_workqueue you can pass a format string and don't
need the separate allocation.

But I'm not sure if Tejun is fine with using __WQ_LEGACY directly..
The only thing that flag does is exempting the workqueue from possible
flush deadlock check as we don't know whether WQ_MEM_RECLAIM on a
legacy workqueue is intentional. There's no reason to add it when
converting to alloc_ordered_workqueue(). Just decide whether it needs
forward progress guarantee and use WQ_MEM_RECLAIM if so.
Cathy?


Sorry for the delay. Long was working on a similar problem and we needed to add a couple of extra patches. I was thinking of sending all three in series but I can send the V3 of this now and follow up with the additional patches. Does that make sense?