Re: [PATCH V8 2/2] printk: hash addresses printed with %p

From: Tobin C. Harding
Date: Mon Oct 30 2017 - 22:00:14 EST


On Mon, Oct 30, 2017 at 08:00:46PM -0400, Steven Rostedt wrote:
> On Tue, 31 Oct 2017 09:41:02 +1100
> "Tobin C. Harding" <me@xxxxxxxx> wrote:
>
>
> > Cool. So I think we need
> >
> > get_random_bytes(&ptr_key, sizeof(ptr_key));
>
> You'll need to add a comment here to describe what ordering the memory
> barrier is used against. That is, somewhere else there's something that
> needs to see the "true" after the "get_random_bytes" update. Describe
> it here.

Got it, thanks Tobin.