Re: [PATCH] nlm_shutdown_hosts_net() cleanup

From: Vasily Averin
Date: Mon Oct 30 2017 - 10:58:57 EST


On 2017-10-30 17:49, J. Bruce Fields wrote:
> On Mon, Oct 30, 2017 at 04:47:58PM +0300, Vasily Averin wrote:
>> nlm_complain_hosts() walk through nlm_server_hosts hlist that should be
>> protected by nlm_host_mutex.
>
> I haven't looked at the NLM locking in ages. Do we know who else might
> actually be accessing this list concurrently?

Thank you for the question, I'll investigate it.

>> Signed-off-by: Vasily Averin <vvs@xxxxxxxxxxxxx>
>> ---
>> fs/lockd/host.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/lockd/host.c b/fs/lockd/host.c
>> index d716c99..089c1d7 100644
>> --- a/fs/lockd/host.c
>> +++ b/fs/lockd/host.c
>> @@ -617,9 +617,8 @@ nlm_shutdown_hosts_net(struct net *net)
>>
>> /* Then, perform a garbage collection pass */
>> nlm_gc_hosts(net);
>> - mutex_unlock(&nlm_host_mutex);
>> -
>> nlm_complain_hosts(net);
>> + mutex_unlock(&nlm_host_mutex);
>> }
>>
>> /*
>> --
>> 2.7.4
>