RE: [PATCH v10 0/9] LPC: legacy ISA I/O support

From: Gabriele Paoloni
Date: Mon Oct 30 2017 - 07:39:38 EST


Hi David

[...]

> FWIW my thoughts on this are WTF!
>
> Looks to me horribly over complicated and over generalised.
>
> Surely is it could be done the same way that x86 does IO cycles?

No

> So you encode the information into the 'address' the driver passes
> to ioread16() (etc) to allow it to do either a normal bus cycle or
> the indirect cycle onto the external bus.

In order to do that you need to have a special PCI bridge that is able
to detect the special IO addresses and initiate such special IO cycles
on the external bus. This is not supported by our HW (and this why
we need the LPC accessors)

Gab

>
> So you have one kernel option that makes these real functions.
>
> David