Re: [f2fs-dev] [PATCH 2/2] f2fs: relax EIO injection for quota file

From: Jaegeuk Kim
Date: Mon Oct 30 2017 - 05:21:19 EST


On 10/28, Chao Yu wrote:
> Hi Jaegeuk,
>
> On 2017/10/23 0:51, Jaegeuk Kim wrote:
> > On 10/22, Chao Yu wrote:
> >> On 2017/10/20 0:56, Jaegeuk Kim wrote:
> >>> This case is not happening easily.
> >>
> >> Actually it can happen, so why not just keep it?
> >
> > Okay, so let me keep this patch for local stress tests only.
>
> May I ask which type and rate of fault injection you are using for
> test now?

I select random value between 3000 and 5000, and 255 for type.

Thanks,

>
> Thanks,
>
> >
> > Thanks,
> >
> >
> >>
> >> Thanks,
> >>
> >>>
> >>> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> >>> ---
> >>> fs/f2fs/f2fs.h | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> >>> index e0ef31cb2cc6..6301ccca8888 100644
> >>> --- a/fs/f2fs/f2fs.h
> >>> +++ b/fs/f2fs/f2fs.h
> >>> @@ -1544,7 +1544,7 @@ static inline int inc_valid_block_count(struct f2fs_sb_info *sbi,
> >>> return ret;
> >>>
> >>> #ifdef CONFIG_F2FS_FAULT_INJECTION
> >>> - if (time_to_inject(sbi, FAULT_BLOCK)) {
> >>> + if (!IS_NOQUOTA(inode) && time_to_inject(sbi, FAULT_BLOCK)) {
> >>> f2fs_show_injection_info(FAULT_BLOCK);
> >>> release = *count;
> >>> goto enospc;
> >>>
> >
> > .
> >