Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

[Eric Wheeler]

On Tue, 10 Oct 2017, Michael Lyle wrote:

> On 10/10/2017 05:25 AM, Coly Li wrote:
> > On 2017/10/10 äå5:00, Liang Chen wrote:
> >> mutex_destroy does nothing most of time, but it's better to call
> >> it to make the code future proof and it also has some meaning
> >> for like mutex debug.
> >>
> >> As Coly pointed out in a previous review, bcache_exit() may not be
> >> able to handle all the references properly if userspace registers
> >> cache and backing devices right before bch_debug_init runs and
> >> bch_debug_init failes later. So not exposing userspace interface
> >> until everything is ready to avoid that issue.
> >>
> >> Signed-off-by: Liang Chen <liangchen.linux@xxxxxxxxx>
> > 
> > Hi Liang,
> > 
> > No more comment from me, it looks good. Thanks.
> > 
> > Reviewed-by: Coly Li <colyli@xxxxxxx>
> 
> Looks good to me too.
> 
> Reviewed-by: Michael Lyle <mlyle@xxxxxxxx>

Should this Cc: stable to avoid the register race (possible 
crash?) described by Liang in other stable kernels?

Reviewed-by: Eric Wheeler <bcache@xxxxxxxxxxxxxxxxxx>

> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>