Re: [PATCH] x86/alternatives: free smp_alt_modules when enable smp

From: Borislav Petkov
Date: Fri Oct 27 2017 - 03:49:22 EST


On Fri, Oct 27, 2017 at 03:18:12PM +0800, Zhou Chengming wrote:
> In the current code, we don't free smp_alt_modules when enable smp,
> so have to wait module unload to call alternatives_smp_module_del()
> to free its smp_alt_module. This strategy has shortcomings.

I love it when the commit message states there is allegedly some problem
but it doesn't explain what that problem is.

>From the looks of the patch, though, I'd prefer what we do now and not
touch the code.

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)
--