Re: [PATCH 1/3] dt-bindings: iio: adc: stm32: add support for diff channels

From: Jonathan Cameron
Date: Tue Oct 24 2017 - 14:43:07 EST




On 24 October 2017 17:41:38 BST, Rob Herring <robh@xxxxxxxxxx> wrote:
>On Tue, Oct 17, 2017 at 03:15:43PM +0200, Fabrice Gasnier wrote:
>> STM32H7 ADC channels may be configured either as single-ended or
>> differential.
>> Add 'st,adc-diff-channels' property to support differential channels.
>> Differential channels are defined as a pair of positive and negative
>> inputs: vinp & vinn.
>>
>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxx>
>> ---
>> Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt | 6
>++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git
>a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt
>b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt
>> index 48bfcaa3..c3c8de1 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt
>> +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt
>> @@ -62,6 +62,12 @@ Required properties:
>> - st,adc-channels: List of single-ended channels muxed for this ADC.
>> It can have up to 16 channels on stm32f4 or 20 channels on
>stm32h7, numbered
>> from 0 to 15 or 19 (resp. for in0..in15 or in0..in19).
>> +- st,adc-diff-channels: List of differential channels muxed for this
>ADC.
>> + Depending on part used, some channels can be configured as
>differential
>> + instead of single-ended (e.g. stm32h7). List here positive and
>negative
>> + inputs pairs as <vinp vinn>, <vinp vinn>,... vinp and vinn are
>numbered
>> + from 0 to 19 on stm32h7)
>> + Note: At least one of "st,adc-channels" or "st,adc-diff-channels"
>is required.
>
>Wouldn't both present be invalid?
>

Probably invalid to have a number in both but some channels in each would be fine.

>> - #io-channel-cells = <1>: See the IIO bindings section "IIO
>consumers" in
>> Documentation/devicetree/bindings/iio/iio-bindings.txt
>>
>> --
>> 1.9.1
>>

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.