Re: [PATCH v2 09/15] ACPI: configfs: make config_item_type const

From: Rafael J. Wysocki
Date: Mon Oct 16 2017 - 20:20:42 EST


On Monday, October 16, 2017 5:18:48 PM CEST Bhumika Goyal wrote:
> Make these structures const as they are either passed to the functions
> having the argument as const or stored as a reference in the "ci_type"
> const field of a config_item structure.
>
> Done using Coccienlle.
>
> Signed-off-by: Bhumika Goyal <bhumirks@xxxxxxxxx>
> ---
> * Changes in v2- Combine all the followup patches and the constification
> patches into a series.
>
> drivers/acpi/acpi_configfs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/acpi_configfs.c b/drivers/acpi/acpi_configfs.c
> index 853bc7f..b588503 100644
> --- a/drivers/acpi/acpi_configfs.c
> +++ b/drivers/acpi/acpi_configfs.c
> @@ -204,7 +204,7 @@ struct configfs_attribute *acpi_table_attrs[] = {
> NULL,
> };
>
> -static struct config_item_type acpi_table_type = {
> +static const struct config_item_type acpi_table_type = {
> .ct_owner = THIS_MODULE,
> .ct_bin_attrs = acpi_table_bin_attrs,
> .ct_attrs = acpi_table_attrs,
> @@ -237,12 +237,12 @@ struct configfs_group_operations acpi_table_group_ops = {
> .drop_item = acpi_table_drop_item,
> };
>
> -static struct config_item_type acpi_tables_type = {
> +static const struct config_item_type acpi_tables_type = {
> .ct_owner = THIS_MODULE,
> .ct_group_ops = &acpi_table_group_ops,
> };
>
> -static struct config_item_type acpi_root_group_type = {
> +static const struct config_item_type acpi_root_group_type = {
> .ct_owner = THIS_MODULE,
> };
>
>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>