Re: [PATCH][net-next] cxgb4: fix missing break in switch and indent return statements

From: David Miller
Date: Sat Oct 14 2017 - 21:38:37 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Fri, 13 Oct 2017 17:29:00 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The break statement for the Macronix case is missing and will
> fall through to the Winbond case and re-assign the size setting.
> Fix this by adding the missing break statement. Also correctly
> indent the return statements.
>
> Detected by CoverityScan, CID#1458020 ("Missing break in switch")
>
> Fixes: 96ac18f14a5a ("cxgb4: Add support for new flash parts")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied.