Re: [PATCH] xfs: move two more RT specific functions into CONFIG_XFS_RT

From: Dave Chinner
Date: Fri Oct 13 2017 - 18:10:53 EST


On Fri, Oct 13, 2017 at 02:05:40PM +0200, Arnd Bergmann wrote:
> The last cleanup introduced two harmless warnings:
>
> fs/xfs/xfs_fsmap.c:480:1: warning: '__xfs_getfsmap_rtdev' defined but not used
> fs/xfs/xfs_fsmap.c:372:1: warning: 'xfs_getfsmap_rtdev_rtbitmap_helper' defined but not used
>
> This moves those two functions as well.

Curious. I didn't get those warnings on gcc 6.4 or 7.2 on x86-64.

Oh, CONFIG_XFS_DEBUG=y hides them, because it removes the "static"
declaration from them. Ok, that makes sense - I almost never build
a non-debug kernel. Have to make sure when I do config changes next
time to build without debug...

Thanks, Arnd!

Cheers,

Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx