Re: [PATCH v1 24/25] kdb: Switch to use %pt

[Arnd Bergmann]

On Thu, Jun 8, 2017 at 3:48 PM, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
> index c8146d53ca67..2a6f12be79d8 100644
> --- a/kernel/debug/kdb/kdb_main.c
> +++ b/kernel/debug/kdb/kdb_main.c
> @@ -2556,12 +2556,7 @@ static int kdb_summary(int argc, const char **argv)
>
>         now = __current_kernel_time();
>         kdb_gmtime(&now, &tm);
> -       kdb_printf("date       %04d-%02d-%02d %02d:%02d:%02d "
> -                  "tz_minuteswest %d\n",
> -               1900+tm.tm_year, tm.tm_mon+1, tm.tm_mday,
> -               tm.tm_hour, tm.tm_min, tm.tm_sec,
> -               sys_tz.tz_minuteswest);
> -

I just experimented with a similar change and noticed your version.

You forgot to remove the kdb_gmtime() function that is now completely
unneeded. My patch takes care of that now.

      Arnd