Re: [PATCH 1/4] perf/ftrace: Revert ("perf/ftrace: Fix double traces of perf on ftrace:function")

From: Steven Rostedt
Date: Wed Oct 11 2017 - 08:58:04 EST


On Wed, 11 Oct 2017 09:45:29 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> Revert commit:
>
> 75e8387685f6 ("perf/ftrace: Fix double traces of perf on ftrace:function")
>
> The reason I instantly stumbled on that patch is that it only addresses the
> ftrace situation and doesn't mention the other _5_ places that use this
> interface. It doesn't explain why those don't have the problem and if not, why
> their solution doesn't work for ftrace.
>
> It doesn't, but this is just putting more duct tape on.
>
> Cc: Zhou Chengming <zhouchengming1@xxxxxxxxxx>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>

Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

-- Steve