Re: [PATCH v15 5/7] vfio: ABI for mdev display dma-buf operation

From: Gerd Hoffmann
Date: Wed Oct 11 2017 - 02:27:23 EST


Hi,

> No, the parameter wouldn't be a char, you'd use an __u32 for the
> dmabuf_id.ÂÂI'm just referencing the structure of the GET_DEVICE_FD
> as
> an ioctl which returns an fd through the return value and takes a
> single parameter.ÂÂI don't mean to imply matching the type of that
> parameter.

> ÂÂGerd, what are your thoughts on that, it'd make it slightly
> easier to call GET_GFX_DMABUF, but it limits us to file descriptor
> for
> the dmabuf whereas with a flag and expandable structure we could use
> some future mechanism to return the dmabuf to userspace.

It's fine with me.

The point of using fd's to refer to dmabufs is that they can be passed
around easily, so I doubt this is going to change.

cheers,
Gerd