Re: [RFC] ARC: [plat-hsdk]: Increase SDIO CIU frequency to 50000000Hz

[Alexey Brodkin]

Hi Vineet,

On Tue, 2017-10-10 at 10:09 -0700, Vineet Gupta wrote:
> On 10/10/2017 09:11 AM, Eugeniy Paltsev wrote:
> > 
> > Increase SDIO CIU frequency from 12500000Hz to 50000000Hz by
> > switching from the default divisor value (div-by-8) to the
> > minimum possible value of the divisor (div-by-2) in HSDK platform
> > code.
> 
> Please describe the problem first not the solution. That some SD cards don't workÂ
> blah blah ....
> You could add me as reported-by - just for completeness !
> 
> While I will test it to see if it cures my issue, I'll need Alexey to sign off /Â
> ack as well !

Sure once you update us with your findings and we know it helps you
(at least Bonnie++ stress-test with one of SD-cards here still works)
there will be a "normal" patch which I'll ack.

-Alexey

> 
> -Vineet
> 
> > 
> > 
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx>
> > ---
> > NOTE: This patch can possibly fix last issue with SD card initialization
> > fault.
> > 
> > Â arch/arc/boot/dts/hsdk.dtsÂÂÂÂ| 11 ++++++-----
> > Â arch/arc/plat-hsdk/platform.c |ÂÂ7 +++++++
> > Â 2 files changed, 13 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> > index 8adde1b..8f627c2 100644
> > --- a/arch/arc/boot/dts/hsdk.dts
> > +++ b/arch/arc/boot/dts/hsdk.dts
> > @@ -137,14 +137,15 @@
> > ÂÂ			/*
> > ÂÂ			Â* DW sdio controller has external ciu clock divider
> > ÂÂ			Â* controlled via register in SDIO IP. Due to its
> > -			Â* unexpected default value (it should devide by 1
> > -			Â* but it devides by 8) SDIO IP uses wrong clock and
> > +			Â* unexpected default value (it should divide by 1
> > +			Â* but it divides by 8) SDIO IP uses wrong clock and
> > ÂÂ			Â* works unstable (see STAR 9001204800)
> > +			Â* We switched to the minimum possible value of the
> > +			Â* divisor (div-by-2) in HSDK platform code.
> > ÂÂ			Â* So add temporary fix and change clock frequency
> > -			Â* from 100000000 to 12500000 Hz until we fix dw sdio
> > -			Â* driver itself.
> > +			Â* to 50000000 Hz until we fix dw sdio driver itself.
> > ÂÂ			Â*/
> > -			clock-frequency = <12500000>;
> > +			clock-frequency = <50000000>;
> > ÂÂ			#clock-cells = <0>;
> > ÂÂ		};
> > ÂÂ
> > diff --git a/arch/arc/plat-hsdk/platform.c b/arch/arc/plat-hsdk/platform.c
> > index 744e62e..f0cdb13 100644
> > --- a/arch/arc/plat-hsdk/platform.c
> > +++ b/arch/arc/plat-hsdk/platform.c
> > @@ -74,6 +74,10 @@ static void __init hsdk_set_cpu_freq_1ghz(void)
> > ÂÂ		pr_err("Failed to setup CPU frequency to 1GHz!");
> > Â }
> > ÂÂ
> > +#define SDIO_BASE		(ARC_PERIPHERAL_BASE + 0xA000)
> > +#define SDIO_UHS_REG_EXT	(SDIO_BASE + 0x108)
> > +#define SDIO_UHS_REG_EXT_DIV_2	(2 << 30)
> > +
> > Â static void __init hsdk_init_early(void)
> > Â {
> > ÂÂ	/*
> > @@ -89,6 +93,9 @@ static void __init hsdk_init_early(void)
> > ÂÂ	/* Really apply settings made above */
> > ÂÂ	writel(1, (void __iomem *) CREG_PAE_UPDATE);
> > ÂÂ
> > +	/* Switch SDIO external ciu clock divider from div-by-8 to div-by-2 */
> > +	iowrite32(SDIO_UHS_REG_EXT_DIV_2, (void __iomem *) SDIO_UHS_REG_EXT);
> > +
> > ÂÂ	/*
> > ÂÂ	Â* Setup CPU frequency to 1GHz.
> > ÂÂ	Â* TODO: remove it after smart hsdk pll driver will be introduced.
>