Re: [PATCH RFC tip/core/rcu 12/15] lib/assoc_array: Remove smp_read_barrier_depends()

From: Paul E. McKenney
Date: Tue Oct 10 2017 - 12:05:35 EST


On Tue, Oct 10, 2017 at 05:54:51PM +0200, Peter Zijlstra wrote:
> On Tue, Oct 10, 2017 at 08:50:42AM -0700, Paul E. McKenney wrote:
> > + /* We need a barrier between the read of the pointer,
> > + * which is supplied by the above READ_ONCE().
> > */
>
> > /* We need a barrier between the read of the pointer
> > * and dereferencing the pointer - but only if we are
> > * actually going to dereference it.
> > */
>
> Could you also fix those "disgusting drug-induced crap" comment styles
> while you're there anyway?
>
> http://lkml.iu.edu/hypermail/linux/kernel/1607.1/00627.html

If Dave is OK with it, I will do so on my next pass.

Thanx, Paul