Re: [PATCH] x86/tsc: Append description for 'tsc=unstable' boot parameter

[Dou Liyang]

Hi Pavel,

At 10/09/2017 08:25 PM, Pavel Tatashin wrote:
> Hi Dou,
>
> Have you tested tsc=unstable with your DR setup? Is it working as
> expected? I mean instead of previous "notsc"?

Not yet, I have applied for the machine, I'll start testing once I have
access to it. And I am looking at this part of code to prepare for the
test. :-)

> Reviewed-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
Thank you very much.

Thanks,
	dou.

> Thank you,
> Pavel
>
> On Mon, Oct 9, 2017 at 5:03 AM, Dou Liyang <douly.fnst@xxxxxxxxxxxxxx> wrote:
> > Commit 8309f86cd41e ("x86/tsc: Provide 'tsc=unstable' boot parameter") adds
> > a new parameter 'tsc=unstable', but doesn't add some description to guide
> > users.
> >
> > Append the description of 'tsc=unstable' at the end of 'tsc=' section.
> >
> > Signed-off-by: Dou Liyang <douly.fnst@xxxxxxxxxxxxxx>
> > ---
> >  Documentation/admin-guide/kernel-parameters.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> > index 9a84483..33e83b6 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -4196,6 +4196,9 @@
> >                         Used to run time disable IRQ_TIME_ACCOUNTING on any
> >                         platforms where RDTSC is slow and this accounting
> >                         can add overhead.
> > +                       [x86] unstable: mark tsc clocksource as unstable, this
> > +                       marks the TSC unconditionally unstable at bootup and
> > +                       avoids any further wobbles once the TSC watchdog notices.
> >
> >         turbografx.map[2|3]=    [HW,JOY]
> >                         TurboGraFX parallel port interface
> > --
> > 2.5.5