Re: [PATCH v2 27/31] usb/gadget/snps_udc_core: Remove struct timer_list.data use

From: Felipe Balbi
Date: Thu Sep 28 2017 - 05:36:49 EST


Kees Cook <keescook@xxxxxxxxxxxx> writes:

> If the probe fails, udc_remove() will not be called, so there is no
> reason to make del_timer_sync() calls conditional. As a result, use of
> the .data field can be dropped, in support of making removing this field
> entirely from struct timer_list.
>
> Cc: Felipe Balbi <balbi@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Raviteja Garimella <raviteja.garimella@xxxxxxxxxxxx>
> Cc: Michal Nazarewicz <mina86@xxxxxxxxxx>
> Cc: "Gustavo A. R. Silva" <garsilva@xxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>

--
balbi

Attachment: signature.asc
Description: PGP signature