Re: [PATCH] PM / PCI: Do not resume any devices in pci_pm_prepare()

From: Rafael J. Wysocki
Date: Tue Sep 26 2017 - 17:39:35 EST


On Tue, Sep 26, 2017 at 11:34 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> On Mon, Sep 25, 2017 at 01:33:13AM +0200, Rafael J. Wysocki wrote:
>> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>>
>> It should not be necessary to resume devices with ignore_children set
>> in pci_pm_prepare(), because they should be resumed explcitly by
>
> s/explcitly/explicitly/

Yup.

>> their children drivers during suspend if need be and they will be
>> resumed by pci_pm_suspend() after that anyway, so avoid doing that.
>>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>
> I think your previous patches to this file mostly used a "PCI / PM"
> subject line prefix (as opposed to the "PM / PCI" here). But maybe
> the difference means something?

No, it doesn't. I'll change it to match the previous ones. :-)

Thanks,
Rafael