Re: [PATCH] s390/sclp: Use setup_timer and mod_timer

From: Martin Schwidefsky
Date: Mon Sep 25 2017 - 01:24:07 EST


On Sun, 24 Sep 2017 17:30:14 +0530
Himanshu Jha <himanshujha199640@xxxxxxxxx> wrote:

> Use setup_timer and mod_timer API instead of structure assignments.
>
> This is done using Coccinelle and semantic patch used
> for this as follows:
>
> @@
> expression x,y,z,a,b;
> @@
>
> -init_timer (&x);
> +setup_timer (&x, y, z);
> +mod_timer (&a, b);
> -x.function = y;
> -x.data = z;
> -x.expires = b;
> -add_timer(&a);
>
> Signed-off-by: Himanshu Jha <himanshujha199640@xxxxxxxxx>
> ---
> drivers/s390/char/sclp_con.c | 7 ++-----
> drivers/s390/char/sclp_tty.c | 7 ++-----
> 2 files changed, 4 insertions(+), 10 deletions(-)

Added to s390/linux for the 4.15 merge window, thanks.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.