Re: [PATCH] HID: core: assign usbhid to handle EETI PID=0x0001 HID device

[Boszormenyi Zoltan]

Hi,

On 2017-08-22 11:33, Benjamin Tissoires wrote:
> On Aug 11 2017 or thereabouts, JamChen wrote:
> > From: Jam Chen <jam.chen.egalax@xxxxxxxxx>
> >
> > The vendor used the same PID(0x0001) for multiple touch IC controllers.
> > The newer ICs can support HID class and report the multitouch collection
> > in the descriptor. So they were handled by the hid-multitouch driver.
> > But some customized firmwares don't support multitouch protocol even if
> > driver have got the Win8 blob data.
> >
> > Actually, those ICs only support the single touch function, and report
> > the mouse protocol by default. We can assign usbhid to handle them all.
> >
> > Signed-off-by: Jam Chen <jam.chen.egalax@xxxxxxxxx>
> > ---
>
> Him
>
> FYI, I'd rather see a full working solution such as the one presented here:
> https://patchwork.kernel.org/patch/9876649/
>
> Because this solution is half working as it regresses on some devices
> while solving others.
>
> Cheers,
> Benjamin

is there any news about resolving this issue in the upstream kernel?

Thanks in advance,
ZoltÃn BÃszÃrmÃnyi

> >   drivers/hid/hid-core.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > index 9017dcc14502..df4696022488 100644
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -828,6 +828,10 @@ static int hid_scan_report(struct hid_device *hid)
> >   				 */
> >   				hid->group = HID_GROUP_RMI;
> >   		break;
> > +	case USB_VENDOR_ID_DWAV:
> > +		if (hid->product == USB_DEVICE_ID_EGALAX_TOUCHCONTROLLER)
> > +			hid->group = HID_GROUP_GENERIC;
> > +		break;
> >   	}
> >   
> >   	/* fall back to generic driver in case specific driver doesn't exist */
> > --
> > 2.11.0