Re: [PATCH] arm64: dts: foundation-v8: Enable PSCI mode

[Daniel Thompson]

On 18/09/17 17:12, Mark Rutland wrote:
> Hi Daniel,
>
> On Mon, Sep 18, 2017 at 04:38:32PM +0100, Daniel Thompson wrote:
> > Currently if the Foundation model is running ARM Trusted Firmware then
> > the kernel, which is configured to use spin tables, cannot start secondary
> > processors or "power off" the simulation.
> >
> > Add a couple of labels to the include file, and introduce a new .dts
> > file that uses these to override the enable-method.
> >
> > Signed-off-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
>
> This looks good, but has the unfortunate effect of leaving the
> (irrelevant) cpu-release-addr property in the PSCI dts files, as that's
> in the underlying dtsi file.
>
> Could we split spin-table / PSCI parts into separate dtsi files?
>
> e.g. have:
>
> * foundation-v8.dtsi
> * foundation-v8-gicv{2,3}.dtsi
> * foundation-v8-{psci,spin-table}.dtsi
>
> ... and then combine those to build the dts files we want.

Will do.

> FWIW, with that:
>
> Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Talking about what we want... if it's all split out I might as well add 
a gicv2+psci DT as well. Will that still retain your Acked-by or do you 
want to see it first ;-) ?


Daniel.