Re: [PATCH RFC V2 05/10] perf tools: lock to protect thread list

From: Jiri Olsa
Date: Mon Sep 18 2017 - 04:51:06 EST


On Sun, Sep 10, 2017 at 07:23:18PM -0700, kan.liang@xxxxxxxxx wrote:

SNIP

> + pthread_mutex_unlock(&thread->namespaces_lock);
> +
> return 0;
> }
>
> -void thread__namespaces_id(const struct thread *thread,
> +void thread__namespaces_id(struct thread *thread,
> u64 *dev, u64 *ino)
> {
> struct namespaces *ns;
>
> + pthread_mutex_lock(&thread->namespaces_lock);
> ns = thread__namespaces(thread);

isn't it just thread__namespaces that needs this lock?

if that's the case we don't need the change for __hists__add_entry
in previous patch

jirka