Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac

From: Borislav Petkov
Date: Thu Aug 31 2017 - 12:52:25 EST


On Thu, Aug 31, 2017 at 04:17:07PM +0000, Kani, Toshimitsu wrote:
> I followed in the footsteps of 'ghes_disable', which is also a kernel
> boot option and uses 0.

Ok, ghes_disable comment says that using module_param() is easier.
ghes_edac is not a module but then __setup() is for "really core code".

Documentation/admin-guide/kernel-parameters.rst also talks about
core_param() but that's #ifndef MODULE. So module_param() it is.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.