Re: [PATCH v2] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources

From: Rafael J. Wysocki
Date: Wed Aug 30 2017 - 19:38:14 EST


On Monday, August 28, 2017 8:13:14 PM CEST Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
>
> ACPI defines a number of instructions to use for triggering errors. However
> we are currently removing the address resources from the trigger resources
> for only the WRITE_REGISTER_VALUE instruction. This leads to a resource
> conflict for any other valid instruction.
>
> Check that the instruction is less than or equal to the
> WRITE_REGISTER_VALUE instruction. This allows all valid memory access
> instructions and protects against invalid instructions.
>
> Fixes: b4e008dc53a3 ("ACPI, APEI, EINJ, Refine the fix of resource conflict")
> Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> Acked-by: Tony Luck <tony.luck@xxxxxxxxx>
> ---
> Link:
> https://lkml.kernel.org/r/1502387883-16667-1-git-send-email-Yazen.Ghannam@xxxxxxx
>
> v1->v2:
> * Apply Tony's comment to restrict behavior to valid memory instructions.

Applied, thanks!