Re: [PATCH] vfio: platform: constify amba_id

From: Alex Williamson
Date: Wed Aug 30 2017 - 17:24:44 EST


On Wed, 23 Aug 2017 22:47:15 +0530
Arvind Yadav <arvind.yadav.cs@xxxxxxxxx> wrote:

> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> ---
> drivers/vfio/platform/vfio_amba.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/platform/vfio_amba.c b/drivers/vfio/platform/vfio_amba.c
> index 31372fb..62dfbfe 100644
> --- a/drivers/vfio/platform/vfio_amba.c
> +++ b/drivers/vfio/platform/vfio_amba.c
> @@ -93,7 +93,7 @@ static int vfio_amba_remove(struct amba_device *adev)
> return -EINVAL;
> }
>
> -static struct amba_id pl330_ids[] = {
> +static const struct amba_id pl330_ids[] = {
> { 0, 0 },
> };
>

Applied to next branch for v4.14. Thanks,

Alex