Re: [PATCH 0/5] net: mdio-mux: Misc fix

From: Andrew Lunn
Date: Wed Aug 30 2017 - 15:01:29 EST


On Wed, Aug 30, 2017 at 07:46:46PM +0200, Corentin Labbe wrote:
> Hello
>
> This patch series fix minor problems found when working on the
> dwmac-sun8i syscon mdio-mux.

Hi Corentin

In general, a nice patchset.

Looking at the code, there are a few calls to devm_kfree() which look
redundant. This one should probably stay:

if (r) {
mdiobus_free(cb->mii_bus);
devm_kfree(dev, cb);
} else {

but i think the others can go.

Just a suggestion, not a problem if you don't feel like doing this...

Andrew