Re: [PATCH v3] ACPI / APEI: Suppress message if HEST not present

From: Punit Agrawal
Date: Wed Aug 30 2017 - 08:55:09 EST


"Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx> writes:

> On Wednesday, August 30, 2017 12:34:55 PM CEST Punit Agrawal wrote:
>> Borislav Petkov <bp@xxxxxxx> writes:
>>
>> > On Tue, Aug 29, 2017 at 02:20:20PM +0100, Punit Agrawal wrote:
>> >> According to the ACPI specification, firmware is not required to provide
>> >> the Hardware Error Source Table (HEST). When HEST is not present, the
>> >> following superfluous message is printed to the kernel boot log -
>> >>
>> >> [ 3.460067] GHES: HEST is not enabled!
>> >>
>> >> Extend hest_disable variable to track whether the firmware provides this
>> >> table and if it is not present skip any log output. The existing
>> >> behaviour is preserved in all other cases.
>> >>
>> >> Suggested-by: Borislav Petkov <bp@xxxxxxx>
>> >> Signed-off-by: Punit Agrawal <punit.agrawal@xxxxxxx>
>> >> Cc: Borislav Petkov <bp@xxxxxxx>
>> >> Cc: James Morse <james.morse@xxxxxxx>
>> >> ---
>> >>
>> >> Changes in v3:
>> >> * Grouped hest_disable status checking into a switch/case for clarity
>> >>
>> >> drivers/acpi/apei/ghes.c | 7 ++++++-
>> >> drivers/acpi/apei/hest.c | 13 +++++++------
>> >> include/acpi/apei.h | 8 +++++++-
>> >> 3 files changed, 20 insertions(+), 8 deletions(-)
>> >
>> > Reviewed-by: Borislav Petkov <bp@xxxxxxx>
>>
>> Thanks!
>>
>> Hopefully Rafael can pick the patch for the upcoming merge window.
>
> Applied already, should show up in linux-next tomorrow.

Neat! Thanks for picking up the patch.

>
> Thanks,
> Rafael
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html