Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory Processor

[Pavel Machek]

Hi!

> Add a driver for RAVE Supervisory Processor, an MCU implementing
> varoius bits of housekeeping functionality (watchdoging, backlight
> control, LED control, etc) on RAVE family of products by Zodiac
> Inflight Innovations.
> 
> This driver implementes core MFD/serdev device as well as
> communication subroutines necessary for commanding the device.

> diff --git a/Documentation/ABI/testing/sysfs-platform-rave-sp b/Documentation/ABI/testing/sysfs-platform-rave-sp
> new file mode 100644
> index 000000000000..81bdc54ba857
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-platform-rave-sp
> @@ -0,0 +1,35 @@
> +What:		/sys/devices/platform/*/serial*/serial*-*/reset_reason
> +Date:		Aug 2017
> +Contact:	"Andrey Smirnov" <andrew.smirnov@xxxxxxxxx>
> +Description:    (RO) Indicates reason for last reset.
> +
> +		The following values can be reported:
> +		    * 0  -> Normal Power Off
> +		    * 1  -> Hardware Watchdog
> +		    * 2  -> Software Watchdog
> +		    * 3  -> Input Voltage Out Of Range
> +		    * 4  -> Host Requested
> +		    * 5  -> Temperature Out Of Range
> +		    * 6  -> User Requested (via long Power Button press)
> +		    * 7  -> Illegal Configuration Word
> +		    * 8  -> Illegal Insturction

Typo here.

> +		    * 9  -> Illegal Trap
> +		    * 10 -> Unknown
> +		    * 11 -> Crew Panel Requested

Anyway... If you move management chip to .. I don't know, i2c, the
path would change. Also it would be different path on N900. Userland
should not have to deal with this.

And... this should really be string, as the list will need to grow on
different hardware.

Plus we'll really need better explanations. What is difference between
"normal power off" and "host requested"? 

> +What:		/sys/devices/platform/*/serial*/serial*-*/boot_source
> +Date:		Aug 2017
> +Contact:	"Andrey Smirnov" <andrew.smirnov@xxxxxxxxx>
> +Description:    (RW) Indicates currently selected boot source.
> +
> +		The following values are valid:
> +		    * 0  -> SD card
> +		    * 1  -> eMMC
> +		    * 2  -> SPI NOR
> +
> +		NOTE: Setting boot source on RDU1 hardware is
> +		currently not implemented

Same comments apply here.

> +RAVE_SP_DEFINE_SEQ_FILE_PRINT_FUNCTION(part_number_firmware);
> +RAVE_SP_DEFINE_SEQ_FILE_PRINT_FUNCTION(part_number_bootloader);
> +RAVE_SP_DEFINE_SEQ_FILE_PRINT_FUNCTION(copper_rev_deb);
> +RAVE_SP_DEFINE_SEQ_FILE_PRINT_FUNCTION(copper_rev_rmb);
> +RAVE_SP_DEFINE_SEQ_FILE_PRINT_FUNCTION(copper_mod_deb);
> +RAVE_SP_DEFINE_SEQ_FILE_PRINT_FUNCTION(copper_mod_rmb);
> +RAVE_SP_DEFINE_SEQ_FILE_PRINT_FUNCTION(silicon_devid);
> +RAVE_SP_DEFINE_SEQ_FILE_PRINT_FUNCTION(silicon_devrev);

Are these going to debugfs?

								Pavel
								
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature