Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer into a helper function

From: Greg Kroah-Hartman
Date: Wed Aug 30 2017 - 02:10:56 EST


On Tue, Aug 29, 2017 at 05:46:57PM -0700, Sherry Yang wrote:
> Use helper functions buffer_next and buffer_prev instead
> of list_entry to get the next and previous buffers.
>
> Signed-off-by: Sherry Yang <sherryy@xxxxxxxxxxx>
> ---
> drivers/android/binder_alloc.c | 24 +++++++++++++++---------
> 1 file changed, 15 insertions(+), 9 deletions(-)

What changed from the previous version?

Always put the changes below the --- line. Like the documentation says
to do so.

Also, don't I already have these patches in my tree? Do you want me to
revert the existing ones and use the new ones, or what about a fixup
patch for any differences?

confused,

greg k-h