Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static

From: Bjorn Helgaas
Date: Tue Aug 29 2017 - 17:04:08 EST


On Wed, Aug 23, 2017 at 10:47:52AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The boolean no_msi is local to the source and does not need to be in
> global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'no_msi' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Folded into the original patch, thanks!

> ---
> drivers/misc/pci_endpoint_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 1f64d943794d..deb203026496 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -73,7 +73,7 @@ static DEFINE_IDA(pci_endpoint_test_ida);
> #define to_endpoint_test(priv) container_of((priv), struct pci_endpoint_test, \
> miscdev)
>
> -bool no_msi;
> +static bool no_msi;
> module_param(no_msi, bool, 0444);
> MODULE_PARM_DESC(no_msi, "Disable MSI interrupt in pci_endpoint_test");
>
> --
> 2.14.1
>