Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()

From: Dan Carpenter
Date: Tue Aug 29 2017 - 16:36:42 EST


On Wed, Aug 30, 2017 at 12:51:01AM +0530, harsha wrote:
> Hi,
> harsha, this is my real name.

That's your full name that you use to sign legal documents? No last
name? No capital letter at the beginning?

> There is no need to call BUG() over here as this error is not very basic and BUG() tends to bring the system down so calling WARN_ON() is preferable.

In the original code the kernel will call BUG() once but in the new code
it will spam the dmesg forever until you pull the power cord. There is
no improvement.

regards,
dan carpenter