Re: [PATCH v2 10/14] power: supply: bq24190_charger: Add input_current_limit property

From: Sebastian Reichel
Date: Tue Aug 29 2017 - 07:29:21 EST


Hi,

On Tue, Aug 15, 2017 at 10:04:58PM +0200, Hans de Goede wrote:
> Export the input current limit of the charger as a
> POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT property on the charger
> power_supply class device.
>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/supply/bq24190_charger.c | 35 ++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> index 073cd9d..f13f892 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -987,6 +987,33 @@ static int bq24190_charger_set_voltage(struct bq24190_dev_info *bdi,
> ARRAY_SIZE(bq24190_cvc_vreg_values), val->intval);
> }
>
> +static int bq24190_charger_get_iinlimit(struct bq24190_dev_info *bdi,
> + union power_supply_propval *val)
> +{
> + int iinlimit, ret;
> +
> + ret = bq24190_get_field_val(bdi, BQ24190_REG_ISC,
> + BQ24190_REG_ISC_IINLIM_MASK,
> + BQ24190_REG_ISC_IINLIM_SHIFT,
> + bq24190_isc_iinlim_values,
> + ARRAY_SIZE(bq24190_isc_iinlim_values), &iinlimit);
> + if (ret < 0)
> + return ret;
> +
> + val->intval = iinlimit;
> + return 0;
> +}
> +
> +static int bq24190_charger_set_iinlimit(struct bq24190_dev_info *bdi,
> + const union power_supply_propval *val)
> +{
> + return bq24190_set_field_val(bdi, BQ24190_REG_ISC,
> + BQ24190_REG_ISC_IINLIM_MASK,
> + BQ24190_REG_ISC_IINLIM_SHIFT,
> + bq24190_isc_iinlim_values,
> + ARRAY_SIZE(bq24190_isc_iinlim_values), val->intval);
> +}
> +
> static int bq24190_charger_get_property(struct power_supply *psy,
> enum power_supply_property psp, union power_supply_propval *val)
> {
> @@ -1027,6 +1054,9 @@ static int bq24190_charger_get_property(struct power_supply *psy,
> case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX:
> ret = bq24190_charger_get_voltage_max(bdi, val);
> break;
> + case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
> + ret = bq24190_charger_get_iinlimit(bdi, val);
> + break;
> case POWER_SUPPLY_PROP_SCOPE:
> val->intval = POWER_SUPPLY_SCOPE_SYSTEM;
> ret = 0;
> @@ -1078,6 +1108,9 @@ static int bq24190_charger_set_property(struct power_supply *psy,
> case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
> ret = bq24190_charger_set_voltage(bdi, val);
> break;
> + case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
> + ret = bq24190_charger_set_iinlimit(bdi, val);
> + break;
> default:
> ret = -EINVAL;
> }
> @@ -1099,6 +1132,7 @@ static int bq24190_charger_property_is_writeable(struct power_supply *psy,
> case POWER_SUPPLY_PROP_CHARGE_TYPE:
> case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT:
> case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
> + case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
> ret = 1;
> break;
> default:
> @@ -1118,6 +1152,7 @@ static enum power_supply_property bq24190_charger_properties[] = {
> POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX,
> POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE,
> POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX,
> + POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT,
> POWER_SUPPLY_PROP_SCOPE,
> POWER_SUPPLY_PROP_MODEL_NAME,
> POWER_SUPPLY_PROP_MANUFACTURER,
> --
> 2.9.4
>

Attachment: signature.asc
Description: PGP signature