RE: [PATCHv2] hv_set_ifconfig.sh double check before setting ip

From: Haiyang Zhang
Date: Mon Aug 28 2017 - 11:56:52 EST




> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@xxxxxxxxxxxxxxxxxx]
> Sent: Monday, August 28, 2017 11:16 AM
> To: Eduardo Otubo <otubo@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; Haiyang
> Zhang <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger
> <sthemmin@xxxxxxxxxxxxx>; David Miller <davem@xxxxxxxxxxxxx>
> Subject: Re: [PATCHv2] hv_set_ifconfig.sh double check before setting ip
>
> On Mon, 28 Aug 2017 12:01:21 +0200
> Eduardo Otubo <otubo@xxxxxxxxxx> wrote:
>
> > v2: The script is now a little bit safer so it doesn't conflicts with
> > network daemon trying to set configurations at the same time.
> >
> > This patch fixes the behavior of the hv_set_ifconfig script when
> setting
> > the interface ip. Sometimes the interface has already been configured
> by
> > network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file
> > exists error"; in order to avoid this error this patch makes sure
> double
> > checks the interface before trying anything.
> >
> > Signed-off-by: Eduardo Otubo <otubo@xxxxxxxxxx>
>
> Adding new dependency on systemd is not going to make this script
> even less useful. I wonder why the script still exists at all? Most of
> the
> Linux distro's can already setup HV networking without it.
>

This script is used by a host to inject IP into guests. KY knows more
details about it.