Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

[Stefan Roese]

On 25.08.2017 12:40, Mika Westerberg wrote:
> On Fri, Aug 25, 2017 at 01:12:51AM -0700, Bin Meng wrote:
> > The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform
> > data. Select it in the Kconfig.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@xxxxxxxxx>
> > ---
> >
> >   drivers/mtd/spi-nor/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> > index bfdfb1e..e998800 100644
> > --- a/drivers/mtd/spi-nor/Kconfig
> > +++ b/drivers/mtd/spi-nor/Kconfig
> > @@ -93,6 +93,7 @@ config SPI_INTEL_SPI_PLATFORM
> >   	tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
> >   	depends on X86
> >   	select SPI_INTEL_SPI
> > +	select LPC_ICH
>
> How about
>
> 	depends on X86 && LPC_ICH
>
> instead?

I prefer Bin's version, as with your patch, the MTD SPI driver will
not be "seen" / selectable, as long as the LPC_ICH support is not
enabled. I've been hunting such dependencies myself a few times and
find them unnecessary burden.

Thanks,
Stefan