Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency

From: Greg Kroah-Hartman
Date: Thu Aug 24 2017 - 19:59:21 EST


On Thu, Aug 24, 2017 at 02:23:08PM -0500, Larry Finger wrote:
> On 08/23/2017 08:22 AM, Arnd Bergmann wrote:
> > Like the version in drivers/net/wireless, this driver requires the
> > MAC80211 framework, otherwise we run into a link error:
> >
> > ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > ERROR: "ieee80211_beacon_get_tim" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > ERROR: "ieee80211_resume_disconnect" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> >
> > This adds the Kconfig dependency for it.
> >
> > Fixes: 56bde846304e ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Greg,
>
> I lost track of which version of this patch you are taking. The one that
> Randy Dunlap sent that added NETDEVICES was better than the initial version,
> but this one with MAC80211 is the correct one. Randy's patch is in the
> latest pull I did on staging.
>
> Do you want an updated patch?

Nope, all should be good now, I've fixed it by hand. Look in my tree
and if it's still wrong there, please send me a fixup.

thanks,

greg k-h