Re: ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()

From: Theodore Ts'o
Date: Thu Aug 24 2017 - 13:44:55 EST


On Sat, Aug 19, 2017 at 08:00:31PM +0200, SF Markus Elfring wrote:
> >> Omit an extra message for a memory allocation failure in this function.
> >
> > I might be dense, but what makes this message "extra?"
> >
> > (I suppose kmalloc squawks too if it fails,
>
> Do you find the default allocation failure report sufficient?

>From a helpdesk reporting situation, having a more specific message
when there is a MMP failure causing the mount to fail is definitely
useful.

So, NACK.

- Ted