Re: [PATCH][V2][netdev-next] gre: remove duplicated assignment of iph

From: David Miller
Date: Thu Aug 24 2017 - 01:36:23 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Wed, 23 Aug 2017 12:59:48 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> iph is being assigned the same value twice; remove the redundant
> first assignment. (Thanks to Nikolay Aleksandrov for pointing out
> that the first asssignment should be removed and not the second)
>
> Fixes warning:
> net/ipv4/ip_gre.c:265:2: warning: Value stored to 'iph' is never read
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Much better, applied, thanks.