Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk()

From: Borislav Petkov
Date: Mon Aug 14 2017 - 15:34:45 EST


On Mon, Aug 14, 2017 at 07:02:15PM +0000, Kani, Toshimitsu wrote:
> I do not know how likely we see such case, but the code should be
> written according to the spec.

Well, then you'll have to make ghes_edac_report_mem_error() reentrant.
Which doesn't look that hard as the only thing it really needs from
struct ghes_edac_pvt are those string buffers. I guess you can try to do
the simplest thing first and allocate them on the stack.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.