Re: [RFT][PATCH] iio: hid-sensor-trigger: Fix the race with user space powering up sensors

From: Srinivas Pandruvada
Date: Sat Aug 12 2017 - 12:04:31 EST


On Sat, 2017-08-12 at 14:58 +0200, Bastien Nocera wrote:
> On Sat, 2017-08-12 at 13:16 +0100, Jonathan Cameron wrote:
> >
> > On Fri, 11 Aug 2017 16:04:30 +0200
> > Bastien Nocera <hadess@xxxxxxxxxx> wrote:
> >
> > >
> > > Woot!
> > >
[...]

> > > >
> > > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxx
> > > > nt
> > > > el.com>ÂÂ
> > > Tested-by: Bastien Nocera <hadess@xxxxxxxxxx>
> > >
> > > I'm still chasing a couple of bugs in the user-space side of
> > > things
> > > caused by the removal of the timeout.
> > >
> > > Thanks!
> > Is it worth me sitting on this for a week or so to see if it deals
> > with
> > all the reported issues around this?
> >
> > Or are you happy that the test set you have is sufficient to verify
> > it?
> I'd rather have it merged ASAP. The fact that it didn't need to sleep
> for 3 seconds allowed me to find a couple of problems in GNOME's use
> of
> this feature, with the sensor showing up before the desktop has
> started. Those will likely be taken care of next week as well.
>
> I've tested it on a couple of machines, and it's working as expected.
>
> >
> > Definitely good to put this one to bed finally!Â
> And no one's happier than me in this one. I can concentrate on bugs I
> wrote myself now ;)
I will resubmit patch by adding Testedby and removing [RFT].

Thanks,
Srinivas